Adar Dembo has submitted this change and it was merged.

Change subject: Enforce LANG=C to check the version of compiler. Otherwise, 
extracting compiler information could fail. One example is here (built on 
CentOS 7).
......................................................................


Enforce LANG=C to check the version of compiler.
Otherwise, extracting compiler information could fail.
One example is here (built on CentOS 7).

LANG is not C
[sarutak@devel release]$ echo $LANG
ja_JP.UTF-8

check the output of `c++ -v` and you'll found it does not match the pattern 
".*gcc version ([0-9\\.]+).*".
[sarutak@devel release]$ c++ -v
組み込み spec を使用しています。
COLLECT_GCC=c++
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper
ターゲット: x86_64-redhat-linux
configure 設定: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla 
--enable-bootstrap --enable-shared --enable-threads=posix 
--enable-checking=release --with-system-zlib --enable-__cxa_atexit 
--disable-libunwind-exceptions --enable-gnu-unique-object 
--enable-linker-build-id --with-linker-hash-style=gnu 
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto --enable-plugin 
--enable-initfini-array --disable-libgcj 
--with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install
 
--with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install
 --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64 
--build=x86_64-redhat-linux
スレッドモデル: posix
gcc バージョン 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC) 

Those conditions end up having a failure of cmake.
[kou@devel-mbp-centos7 release]$ ../../build-support/enable_devtoolset.sh   
../../thirdparty/installed/common/bin/cmake   -DCMAKE_BUILD_TYPE=release   ../..
...
CMake Error at cmake_modules/CompilerInfo.cmake:51 (message):
  Unknown compiler.  Version info:

  組み込み spec を使用しています。

  COLLECT_GCC=/usr/bin/c++

  COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper

  ターゲット: x86_64-redhat-linux

  configure 設定: ../configure --prefix=/usr --mandir=/usr/share/man
  --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla
  --enable-bootstrap --enable-shared --enable-threads=posix
  --enable-checking=release --with-system-zlib --enable-__cxa_atexit
  --disable-libunwind-exceptions --enable-gnu-unique-object
  --enable-linker-build-id --with-linker-hash-style=gnu
  --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto
  --enable-plugin --enable-initfini-array --disable-libgcj
  
--with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install
  
--with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install
  --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64
  --build=x86_64-redhat-linux

  スレッドモデル: posix

  gcc バージョン 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)

Call Stack (most recent call first):
  CMakeLists.txt:218 (include)


-- Configuring incomplete, errors occurred!
See also "/home/kou/work/kudu/build/release/CMakeFiles/CMakeOutput.log".
...
Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Reviewed-on: http://gerrit.cloudera.org:8080/5175
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <[email protected]>
---
M cmake_modules/CompilerInfo.cmake
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a178f503f918aea308b6073b57c2b991d34e848
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Kousuke Saruta <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins

Reply via email to