David Ribeiro Alves has posted comments on this change. Change subject: Allow to skip the scan part of full_stack-insert-scan-test ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5233/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc File src/kudu/integration-tests/full_stack-insert-scan-test.cc: PS1, Line 275: NO_FATALS(DoTestScans()); : } : : TES > nit: may be, move this into the DoTestScans() itself? Done PS1, Line 286: vector<scoped_refptr<Thread> > threads(kNumInsertClients); : CountDownLatch start_latch(kNumInsertClients + 1); : for (int i = 0; i < kNumInsertClients; ++i) { : > ditto Done -- To view, visit http://gerrit.cloudera.org:8080/5233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93e4c0dd5637bb8992f5f2fd51d4f3811e468974 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
