Alexey Serbin has posted comments on this change. Change subject: Remove/downgrade a few very verbose useless log statements ......................................................................
Patch Set 2: > are these useful in your opinion? i know they can be reduced that > way but why keep typing that flag if they never provide value? for > instance if the maintenance manager if disabled, do we really need > to know about it every 100 msecs? As I understand, when using the -vmodule flag, you can enable VLOG() logging only from specific places. E.g., in you case it could be just set of files from which you wanted to collect VLOG() messages, all the rest of VLOG() instances would be silent. E.g., some time ago I ran some tests like client-test --gtest_filter=.... -vmodule batcher=3 to get VLOG messages of level 0 to 3 from batcher.cc file. All VLOG() messages from other places were silenced. Would it be useful in your case? -- To view, visit http://gerrit.cloudera.org:8080/5226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7863f067f49cc7432e8ca3b532a208d3c4005300 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
