Dan Burkert has posted comments on this change. Change subject: [java-client] add missing check for open client ......................................................................
Patch Set 1: This is an interesting failure. The test (https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java#L649) is specifically testing that closing a KuduClient who transitively has unflushed Session buffers will cause the session buffers to be flushed. Somehow the buffers are not flushed by the time the close() method returns, and from a quick look there is no direct link between AsyncKuduClient#close and flushing outstanding sessions. This is potentially problematic, since applications could assume the auto-flushing behavior means that when close returns the Client is all wrapped up, and the application can end. Not sure what to do here, this isn't a pressing issue, so I think we should wait for JD to weigh in on the correct semantics. -- To view, visit http://gerrit.cloudera.org:8080/5190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I405d85a1295bf4e4aac348942d12efba40953a91 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
