David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc ......................................................................
Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/5057/10/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: PS10, Line 228: / and committing this transaction this should not advance the MvccManager : // 'all_committed_before_' watermark. > not quite a sentence Done http://gerrit.cloudera.org:8080/#/c/5057/10/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: PS10, Line 48: // This shouldn't happen in general, so in debug more just crash. > hrm, maybe this shoudl just be a CHECK then? if this happens can't we get a when this returns IllegalState it causes a crash on ScopedTransaction, but I think you're right that is makes more sense to crash here. Done Line 58: strings::Substitute("There is already a transaction with timestamp: $0 in flight or " > same, do we ever expect this to happen? same http://gerrit.cloudera.org:8080/#/c/5057/10/src/kudu/tablet/mvcc.h File src/kudu/tablet/mvcc.h: PS10, Line 186: 'all_committed_before_ > should this be referring to safe_time_ now? seems this all_committed_before removed this since this method no longer returns a status. PS10, Line 220: with timestamp > 'with timestamps equal to' Done PS10, Line 220: anymore > nit: 'any more' Done PS10, Line 360: ID > timestamp Done -- To view, visit http://gerrit.cloudera.org:8080/5057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cd0b8aa52e4b0f5c0f4872d806e76387f6b9538 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
