Alexey Serbin has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens ......................................................................
Patch Set 2: > Would like your thoughts on my q, but I don't think that should be > an impediment to the patch. I see, thank you for the clarification. As for you question, from what I see, I would not expect the thing to break due to that patch if the inter-operability was OK prior to that. Consider two things: * The raw format compatibility is guaranteed by the ProtoBuf * As for the application logic of serializing/de-serializing, the patch does not add any new requirements/expectations on the data contained in the serialized token. I opened a JIRA item on implementing a test for the inter-operability of those tokens: https://issues.apache.org/jira/browse/KUDU-1765 -- To view, visit http://gerrit.cloudera.org:8080/5220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c76c20b62cb91695c69f7dc4b98f4dc98bf02cc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
