Adar Dembo has posted comments on this change. Change subject: bshuf_block: some low-hanging-fruit optimizations on write path ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5195/5/src/kudu/cfile/bshuf_block.h File src/kudu/cfile/bshuf_block.h: Line 174: return kHeaderSize + count_ * size_of_type; Why don't we round up this estimate anymore? -- To view, visit http://gerrit.cloudera.org:8080/5195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia895f7731e5371967782ef9cb176a9d493894a83 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
