Alexey Serbin has posted comments on this change. Change subject: [i-tests] scan token timestamp propagation test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5219/1/src/kudu/integration-tests/consistency-itest.cc File src/kudu/integration-tests/consistency-itest.cc: PS1, Line 611: ASSERT_OK(KuduScanToken::DeserializeIntoScanner(client.get(), scan_token, : &scanner_raw)); > It could be a good solution, however the scan below does not succeed, so th ok, it seems I see what you mean: that's what we should see in case of success. If it fails, it fails and we don't do any conclusions -- that's the essence. All right, this sounds good to me. Will update in a moment. -- To view, visit http://gerrit.cloudera.org:8080/5219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47cd067248f4a26c4605f075ec5ee30da71f6f30 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
