Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp" ......................................................................
KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp" As these ".tmp" strings were scattered over the code, I've tried to remove this duplication as well by defining the single kTmpInfix in path_util.h. In a couple of places it led to string concatenations, but I suppose it's not that bad for overall performance? The necessity of moving from "tmp" to "kudutmp" is backed by the idea that we don't want to remove any user's data accidentally. For example, we may have a symlink to some external directory, which doesn't belong only to Kudu. Hence, we don't want to delete any ordinary tmp files from it. (see https://gerrit.cloudera.org/#/c/5007/). Change-Id: I52a794cc16d008570039d276ab32e6a26829bc53 Reviewed-on: http://gerrit.cloudera.org:8080/5123 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/consensus/log.cc M src/kudu/fs/fs_manager-test.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc M src/kudu/tserver/tablet_copy_client.cc M src/kudu/tserver/tablet_copy_source_session-test.cc M src/kudu/util/path_util.cc M src/kudu/util/path_util.h M src/kudu/util/pb_util.cc 10 files changed, 25 insertions(+), 22 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52a794cc16d008570039d276ab32e6a26829bc53 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Maxim Smyatkin <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
