Alexey Serbin has posted comments on this change.

Change subject: [i-tests] test for timestamp propagation with write ops
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5268/1/src/kudu/integration-tests/consistency-itest.cc
File src/kudu/integration-tests/consistency-itest.cc:

PS1, Line 360: the
> s/the //
Done


PS1, Line 379: at
> missing a word
Done


PS1, Line 403: // If the client propagates the timestamp with write operations,
             :   // the timestamp received from the second server should be 
greater
             :   // than the timestamp received from the first server.
             :   EXPECT_GT(ts, ts_ref);
> can you add a scan at ts+1 and make sure you see both rows?
Good idea -- will do.


-- 
To view, visit http://gerrit.cloudera.org:8080/5268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1be285fd860f0608f5d4ce3be57c4e4b04c63455
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to