Will Berkeley has posted comments on this change.

Change subject: KUDU-981 (part 1): validate identifiers as UTF8 with no null 
bytes
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5296/1//COMMIT_MSG
Commit Message:

PS1, Line 12: limiting to only
            : ASCII
> I'm pretty strongly opposed to this.
Me too. Though Impala does restrict identifiers to ASCII-only. See 
http://www.cloudera.com/documentation/enterprise/5-7-x/topics/impala_identifiers.html


-- 
To view, visit http://gerrit.cloudera.org:8080/5296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3b05e2882c9c2ce9b47c16450d9d54a04d3e38b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to