David Ribeiro Alves has posted comments on this change.

Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time
......................................................................


Patch Set 1:

(1 comment)

Yeah this doesn't try to make it not wait at all, just tries to avoid waiting 
when it would likely be pointless because safe time is so far in the past that 
it's probably not getting to get to 'timestamp' before the client's deadline 
expires.
I assume that in most cases the client's deadline would be bigger than the 
heartbeat interval.

http://gerrit.cloudera.org:8080/#/c/5305/1//COMMIT_MSG
Commit Message:

Line 15: This allowed to swap linked_list-test to finish with snapshot scans
> why not merge the test change in, so this goes in with its end-to-end test 
sure, will do. think it's still worth a unit test or would that be enough?


-- 
To view, visit http://gerrit.cloudera.org:8080/5305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7cd0b0749e715c5d9e665a8e37d0f1c95af574e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to