Matthew Jacobs has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded ......................................................................
Patch Set 1: (3 comments) Thanks! Unit tests? http://gerrit.cloudera.org:8080/#/c/5308/1/src/kudu/client/client.h File src/kudu/client/client.h: Line 1520: /// By default, when a session is created, there is no limit on maximum size. can you comment on what happens when this limit is reached? Line 1521: /// might be worth commenting that errors contain error messages that are potentially large (e.g. containing traces at some point), as well as the partial row. Depending on the error condition and the size of the row, the number of errors this handles may vary. Line 1524: /// where @c 0 means 'unlimited'. is negative also unlimited, or what happens? -- To view, visit http://gerrit.cloudera.org:8080/5308 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9fe3e83bab2a0b703b685ec7f3bb1db1601e5f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
