Adar Dembo has posted comments on this change. Change subject: tool: Allow hyphens to be used instead of underscores ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5311/2/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: Line 113: string ReplaceCopy(string str, char target, char replacement) { Nit: since you always replace hyphens with underscores, how about baking that into the function itself? Fewer arguments to pass around. -- To view, visit http://gerrit.cloudera.org:8080/5311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8bf958ee8841e9624687fb5ae50cc908e3e41c3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
