eric-maynard has posted comments on this change.

Change subject: KUDU-1422 [java client] modifiable error collector capacity
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5291/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:

Line 213:    * Sets the maximum capacity of this session's ErrorCollector.
> I'm a little nervous about this public API, come to think of it, because ty
My thinking is that you'd actually want to specify the number of errors you're 
capturing, not necessarily the size of the buffer that stores the RowError 
objects (since the string message of the RowError can be any arbitrary length, 
and therefore a given RowError can be any arbitrary size). I know that if I 
wanted to capture the first 10 errors, I would have no idea what to set the 
memory usage to. 

I can see how you also might want to limit the memory usage of the buffer 
though. I'm not sure which approach I think is better.


-- 
To view, visit http://gerrit.cloudera.org:8080/5291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae382050eb5eaf9c169dd3ef7ed4dbf5b5f1c334
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: eric-maynard <emayn...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: eric-maynard <emayn...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to