Alexey Serbin has posted comments on this change. Change subject: Allow to build a MonoTime from a MonoDelta ......................................................................
Patch Set 2: > so that we can build a monotime from a timestamp (like the physical > part of a timestamp) and use it for calculations and to add deltas > and whatnot. This sounds a little bit questionable to me. What is the target space of the MonoTime objects built such a way? If it's just Timestamp of uint64_t, I don't think this is needed. Also, what do you think of adding some guardrails to prevent unintentional comparison of MonoTime out from different domains? Like, add some sort of parameter for MonoTime constructor which would represent the domain/field of the object. The comparison operations might them check the domain in debug builds. -- To view, visit http://gerrit.cloudera.org:8080/5325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100e72cf4ac5cf23570e69e32a998253a63c6505 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
