David Ribeiro Alves has posted comments on this change.

Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5309/4/src/kudu/consensus/consensus_queue.h
File src/kudu/consensus/consensus_queue.h:

PS4, Line 137: const OpId& last_locally_committed
> yea, I considered that, but thought it was weird to pass an OpId for one an
i think if would, for consistency. but not worth a patch.


-- 
To view, visit http://gerrit.cloudera.org:8080/5309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f1332d605f7f846a01923b3ab92f12d73462bba
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to