Alexey Serbin has posted comments on this change. Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5319/3//COMMIT_MSG Commit Message: PS3, Line 13: TestWorload TestWorkload PS3, Line 18: This patch changes TestWorkload to use a ThreadSafeRandom. We : could also change the key type to int64 and do something like : int64 key = r.Next32() << 32 | thread_index, however changing : the type of the key is very invasive as a bunch of tests : depend on it. Instead of relying on the implementation of PRNG, why not to give those threads non-intersecting ranges of the target key space (-2^31 to 2^31 - 1 in this case) and then, if those thread, simply do next_key = range_begin + random.Next() % (range_end - range_begin) instead? PS3, Line 24: increses increases PS3, Line 35: mimick mimic -- To view, visit http://gerrit.cloudera.org:8080/5319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35faf53cb9bb8585ec1c01d038b1cd64a0bb533e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
