Adar Dembo has posted comments on this change. Change subject: client: throttle some warning messages when lookup RPCs fail ......................................................................
Patch Set 1: (2 comments) There are some similar LOG() calls in SyncLeaderMasterRpc that you may want to downgrade. They're not in the data path, but it's conceivable to have a stressful workload that makes many DDL calls and generates load via those LOG messages. http://gerrit.cloudera.org:8080/#/c/5332/1/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: Line 197: LOG(WARNING) << "Tablet " << tablet_id_ << ": Replica " << ts->ToString() What about this one? Line 696: LOG(WARNING) << "Failed to determine new Master: " << status.ToString(); Or this one? -- To view, visit http://gerrit.cloudera.org:8080/5332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I840bd57976ccefba4453667f82c7aa32756922d3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
