David Ribeiro Alves has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5304/3/src/kudu/server/hybrid_clock-test.cc File src/kudu/server/hybrid_clock-test.cc: PS3, Line 288: > could you use operator- here instead: this is a old revision http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock.h File src/kudu/server/hybrid_clock.h: PS4, Line 65: GetPhysicalComponentDifference > nit: could you add a comment that the difference is about (a - b), not (b - I added that comment on the Clock class header. Done -- To view, visit http://gerrit.cloudera.org:8080/5304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e5bcd7cb2e9c2b5ce1458c5366d28c385864b0a Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
