Alexey Serbin has posted comments on this change. Change subject: Remove the clock from MvccManager ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5326/2/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: PS2, Line 535: ASSERT_EQ Here and elsewhere: in ASSERT_EQ() the expected value comes as a first parameter. PS2, Line 544: waiting_thread.join(); Consider doing this in the ScopeCleanup object to avoid possible TSAN warning messages if any of the ASSERT checks triggers. -- To view, visit http://gerrit.cloudera.org:8080/5326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b3359fb3e92193f37ebb36063790230a1cac7a8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
