Dan Burkert has posted comments on this change. Change subject: Add file modified time to Env ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: PS1, Line 695: writer->Append(" "); : writer->Sync(); > Shouldn't this be outside of (and before) AssertEventually? Or did you want It needs to do a new append and sync on each iteration, since it needs to update the mtime each iteration. http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env.h File src/kudu/util/env.h: PS1, Line 178: is frequently as high as 1 second > Nit: maybe "may be as high as 1 second on some platforms" to indicate that Done -- To view, visit http://gerrit.cloudera.org:8080/5339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90b3e759a4dbb352a0c09dc726b428c9dcea5595 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
