Dan Burkert has submitted this change and it was merged. Change subject: KUDU-766: limit number of glog files ......................................................................
KUDU-766: limit number of glog files This commit introduces a new flag, 'max_log_files', that limits the maximum number of rolled glog files to keep around at each severity level. This flag matches an Apache Impala flag of the same name, and the implementation is partly borrowed from it. I initially went the route of making a new maintenance manager operation type to schedule the file cleanup, but it proved difficult to shoehorn this usecase into that abstraction. Instead, a thead is spawned on startup that checks for excess files every 60 seconds. Change-Id: Ia3f81638a6dfcf134665322f091ff26d29640fd9 Reviewed-on: http://gerrit.cloudera.org:8080/5340 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h A src/kudu/integration-tests/log-rolling-itest.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/metrics.h 9 files changed, 290 insertions(+), 64 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3f81638a6dfcf134665322f091ff26d29640fd9 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
