David Ribeiro Alves has posted comments on this change.

Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5374/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:

PS2, Line 1538: Timestamp ancient_history_mark;
> nit: consider removing this since it's not needed.
Done


PS2, Line 1548:  
> nit: consider adding comma/semicolon or other
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to