David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement ......................................................................
Patch Set 27: (1 comment) http://gerrit.cloudera.org:8080/#/c/5240/27/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 1204: // All transactions that are going to be prepared were started, advance the safe timestamp. > this doesn't smell quite right: imagine the leader sent: yeah, the comment is misleading likely left over from the leader leases patch. see, when we have those, the leader is free to send safe time with actual uncommitted messages, but until then the leader only sets this timestamp when there are no messages to send. this largely reduces the opportunity for anomalies, at the cost of some extra latency. its a bit conservative, but can be helped with "update me" rpcs which I still have some hope to put up as it should be simple -- To view, visit http://gerrit.cloudera.org:8080/5240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8532fdb069c8bee7f3e08ffe74cab0273885cc8e Gerrit-PatchSet: 27 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
