Dan Burkert has posted comments on this change. Change subject: log block manage: tighten up read only usage ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5383/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 410: if (!block_manager->read_only_ && Shouldn't this still return Status::Aborted if we are in read_only_ mode? Line 499: if (read_status.IsIncomplete() && !block_manager()->read_only_) { Same here - should we return OK but not attempt to repair it? -- To view, visit http://gerrit.cloudera.org:8080/5383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I029527b78148d68a002a3c42af5a52f179089a95 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
