Dan Burkert has posted comments on this change. Change subject: KUDU-1792 It is possible to overwrite range partitions ......................................................................
Patch Set 1: (4 comments) It looks like the python failures might be legitimate, in which case there are python tests relying on the buggy behavior. http://gerrit.cloudera.org:8080/#/c/5395/1/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: PS1, Line 1533: CHECK > ASSERT Done Line 1540: CHECK_OK(row->SetInt32("c0", *value)); > Can you ASSERT_OK here too? No, because it's in a lamda with a non-void return type. Line 1597: } else if (!lower_bound) { > warning: don't use else after return [readability-else-after-return] Done Line 1743: /// Unbounded Above / Unbounded Above > This comment is misplaced, right? Isn't the comment on L1740-L1741 supposed Done -- To view, visit http://gerrit.cloudera.org:8080/5395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89ae162f33de20169848091e518315853be30460 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
