Yanlong Zheng has posted comments on this change.

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5237/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

PS3, Line 529: toString
Sample Output:
 
scala> val kins = ktbl.newInsert()
kins: org.apache.kudu.client.Insert = KuduRpc(method=Write, tablet=null, 
attempt=0, DeadlineTracker(timeout=0, elapsed=2), No traces) (Rowkey int32 key, 
string value)

For insert operation, I think these outputs can help user with the next step 
operation. They can get information about column indexes and types.

Please tell me if you better idea. And should I roll back the changes in 
appendCellValueDebugString?


-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Yanlong Zheng <[email protected]>
Gerrit-HasComments: Yes

Reply via email to