Will Berkeley has posted comments on this change. Change subject: KUDU-861 Support changing default, storage attributes ......................................................................
Patch Set 17: (5 comments) http://gerrit.cloudera.org:8080/#/c/4310/12/src/kudu/common/schema.cc File src/kudu/common/schema.cc: Line 80: if (col_delta.encoding) { > I was curious about this so I tried it out, I think this works correctly: Nice! That's way better. http://gerrit.cloudera.org:8080/#/c/4310/14/src/kudu/common/schema.cc File src/kudu/common/schema.cc: Line 473: > another place where the definition can be hoisted out of the if condition. Done http://gerrit.cloudera.org:8080/#/c/4310/12/src/kudu/common/schema.h File src/kudu/common/schema.h: Line 128: boost::optional<bool> nullable; > I'm not sure I follow - isn't this class entirely new in this patch? Whoops...was thinking of a totally different class. Done. http://gerrit.cloudera.org:8080/#/c/4310/14/src/kudu/common/wire_protocol.h File src/kudu/common/wire_protocol.h: Line 93: // The protobuf must outlive the returned ColumnSchemaDelta. > Note that the protobuf must outlive the returned ColumnSchemaDelta, since i Done http://gerrit.cloudera.org:8080/#/c/4310/14/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: Line 349: TEST_F(AlterTableTest, TestAddChangeRemoveColumnDefaultValue) { > Could you add a string/binary column to the test, and have an alter table o Done -- To view, visit http://gerrit.cloudera.org:8080/4310 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I457d99ba2188ef6e439df47c0d94f2dc1a62ea6c Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
