Mike Percy has submitted this change and it was merged. Change subject: KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica ......................................................................
KUDU-1796: Use last REPLICATE OpId instead of last COMMIT OpId to tombstone a tablet replica The kudu-tool-test has been flaky because of the following failure: kudu-tool-test.cc:1203: Failure Value of: tombstoned_opid.index() Actual: 205 Expected: last_logged_opid.index() Which is: 206 Issue here is, offline cli tool "local_replica delete" stored last COMMIT OpId on the tablet superblock instead of last REPLICATE OpId while tombstoning the tablet replica. Hence kudu-tool-test ToolTest.TestLocalReplicaTombstoneDelete observed that sometimes tombstoned_opid (COMMIT) lagged behind last_logged_opid (REPLICATE). This patch fixes the tool to use the REPLICATE OpId from the WAL. Testing: Ran 5000 iterations of current failing test. Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a Reviewed-on: http://gerrit.cloudera.org:8080/5416 Reviewed-by: Mike Percy <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/tools/tool_action_local_replica.cc 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02e95f05fab80e94b1afd078b23e5e03eca6e42a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
