David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 continue scan if tablet is being deleted ......................................................................
Patch Set 6: (2 comments) lgtm, excepting nits. see my comment on the test patch though. http://gerrit.cloudera.org:8080/#/c/5346/6/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: PS6, Line 1686: PREDICT_FALSE(!s.ok() && !s.IsIllegalState()) nit: you only need to check !s.IsIllegalState() PS6, Line 1686: if (PREDICT_FALSE(!s.ok() && !s.IsIllegalState())) { how about you make this more explicit: if (PREDICT_FALSE(!s.ok() || tablet_ref_error_code != TABLET_NOT_RUNNING) ? -- To view, visit http://gerrit.cloudera.org:8080/5346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica48c52a81862f47a9245003915d18be411bf8b1 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
