Sounds good. Since this was a somewhat controversial change, maybe you could send an email to the devlist laying out the current issue and possible solutions? Having a clear direction will help not get bogged down in the code review again.
Thanks! - Dan On Fri, Dec 9, 2016 at 9:42 AM, Will Berkeley (Code Review) < [email protected]> wrote: > Will Berkeley has abandoned this change. > > Change subject: KUDU-1386 NaN float and double values are not handled > correctly > ...................................................................... > > > Abandoned > > Since this is so old, I'm just going to re-roll this as a new patch > (soon™). > > -- > To view, visit http://gerrit.cloudera.org:8080/3142 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: abandon > Gerrit-Change-Id: I194dcddeb8eabcc67699661b9cc9362a99f2f4ae > Gerrit-PatchSet: 4 > Gerrit-Project: kudu > Gerrit-Branch: master > Gerrit-Owner: Will Berkeley <[email protected]> > Gerrit-Reviewer: Dan Burkert <[email protected]> > Gerrit-Reviewer: Kudu Jenkins > Gerrit-Reviewer: Peter Ebert > Gerrit-Reviewer: Todd Lipcon <[email protected]> > Gerrit-Reviewer: Will Berkeley <[email protected]> >
