David Ribeiro Alves has posted comments on this change.
Change subject: WIP: bug in exactly-once during tablet bootstrap
......................................................................
Patch Set 2:
After digging around a bit more. I think the problem is a bit more insidious
than us just not keeping the error. After fixing that bug I still got a
miscount.
For instance this log entry;
5.24@6067477835358027776 REPLICATE WRITE_OP
Tablet: ca254b0152444e97be34aa60658961da
RequestId: client_id: "5885ac11fece4646a9a014031c6ce856" seq_no: 21
first_incomplete_seq_no: 8 attempt_no: 21
Consistency: CLIENT_PROPAGATED
Propagated TS: 6067477833427873792
op 0: INSERT (int32 key=11, int32 int_val=1590579801, string
string_val="hello world")
op 1: INSERT (int32 key=11, int32 int_val=1908549293, string
string_val="hello world")
op 2: INSERT (int32 key=12, int32 int_val=1209943213, string
string_val="hello world")
Has this commit message:
COMMIT 5.24
op_type: WRITE_OP commited_op_id { term: 5 index: 24 } result { ops {
mutated_stores { mrs_id: 0 } } ops { flushed: true } ops { flushed: true } }
Note that the second key is repeated. so it's weird that the first op on the
commit message applies it to the mrs but the the second op says flushed.
I added a few extra log statements to tablet bootstrap. investingating this
further.
--
To view, visit http://gerrit.cloudera.org:8080/5417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60b3b30b0705b4f9063b0d505cb9ab1ca24e470a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
