Mike Percy has posted comments on this change. Change subject: env: rename writable_file_use_fsync to env_file_use_fsync ......................................................................
Patch Set 1: Code-Review-1 In my opinion you just missed the boat for stuff like this. If you want to do this, I think you should make it backwards compatible with an alias. Unfortunately gflags doesn't support aliases yet so it needs to be a "manual" alias (see https://github.com/gflags/gflags/issues/76 ) -- To view, visit http://gerrit.cloudera.org:8080/5458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66f9b448869885e855558dfc9194aabd17a8644d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
