Adar Dembo has posted comments on this change. Change subject: tests: set never_fsync for every test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5459/1/src/kudu/util/atomic-test.cc File src/kudu/util/atomic-test.cc: Line 23: #include <gtest/gtest.h> > nit: Superfluous when pulling in test_util.h Depends. If you're a believe in strict include-what-you-use, then every "leaf" dependency ought to include every header it uses, even if that header is included via intermediate header (imagine the case where the intermediate header loses that dependency; now a bunch of leaf dependencies don't build). -- To view, visit http://gerrit.cloudera.org:8080/5459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c2574eb3cb76fba1bce0202d4335d8b7035a93 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
