Will Berkeley has posted comments on this change. Change subject: [spark] KUDU-1631 push down StringStartsWith filters ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5461/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: Line 22: import com.google.common.annotations.VisibleForTesting > This isn't being used. Done Line 192: p.reverse.dropWhile(_ == Char.MaxValue).reverse match { > We discussed on Slack how this method can do anywhere between 2 and 6 or 7 ?? -- To view, visit http://gerrit.cloudera.org:8080/5461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb50486fe3f3b44a241a554a953e4e2c81f17be4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
