Alexey Serbin has posted comments on this change. Change subject: WIP: rpc: Initiate TLS connection upgrade following SASL negotiation ......................................................................
Patch Set 1: (2 comments) Just a couple of nits, but so far it looks great. Will take a closer look tonight. http://gerrit.cloudera.org:8080/#/c/5484/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: PS1, Line 640: socket_.reset nit: consider using swap() instead http://gerrit.cloudera.org:8080/#/c/5484/1/src/kudu/rpc/connection.h File src/kudu/rpc/connection.h: PS1, Line 153: bool nit: it seems we do favor enums instead for such cases -- To view, visit http://gerrit.cloudera.org:8080/5484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If44a71186eb2cdeebaf46cc372596f3ee6b47ac0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
