Adar Dembo has posted comments on this change. Change subject: external_mini_cluster: check for leaks before killing servers ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5501/6/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: Line 108: #ifndef LSAN_ENABLED > The problem then is that the '#else' would apply to the outer #if instead o I see. Yeah you'd have to duplicate the resp->set_success(false) call in two places: once if !__has_feature(address_sanitizer), and once if !defined(__has_feature). That's uglier. -- To view, visit http://gerrit.cloudera.org:8080/5501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b6c38281e35e8300e849f92e91d6955a8d735bf Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
