Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5549/2/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java: PS2, Line 202: @Override : public String toString() { : // TODO this method can be removed in the future, it used to add the row's contents. We're : // keeping the method here to not break compatibility. : return super.toString(); : } > How does removing this method break compatibility? Java method dispatch is Then we can remove it again. toString on KuduRpc is pervasive throughout the Java client. The rule here might just be that we can't log user data in toString for KuduRpc daughters. -- To view, visit http://gerrit.cloudera.org:8080/5549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f3dd9dad7bac1d005bd3eead8df33005c7f8c58 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
