Dan Burkert has posted comments on this change. Change subject: WIP: KUDU-1812. Redaction using thread-local boolean approach ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5557/2/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: Line 1012: ASSERT_EQ("`a` = <redacted>", ColumnPredicate::Equality(column_i32, &one_32).ToString()); > I believe Dan's approach redacts the operator of the predicate as well as t I wasn't sure, so erred on the side of over-redaction. If exposing the operator is fine, let's keep it as is. -- To view, visit http://gerrit.cloudera.org:8080/5557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75392ae36e96c1742e478e82671fd1eac3a0edee Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
