Dan Burkert has posted comments on this change. Change subject: WIP: KUDU-1812. redaction of PB fields ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5553/2/src/kudu/util/pb_util.proto File src/kudu/util/pb_util.proto: Line 43: optional bool REDACT = 50001 [default=false]; > The protobuf docs say: I don't think changing the field # would be a breaking change, since this isn't something that's serialized, so I think we should be able to punt on this in the short term. Whether we need to or not in the long term - I'm not sure. -- To view, visit http://gerrit.cloudera.org:8080/5553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
