Dan Burkert has posted comments on this change. Change subject: KUDU-1812. address comments on 1179bbdb ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5566/2/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: PS2, Line 225: FLAGS_logtostderr = true; : bool show_help = ParseCommandLineFlags(&argc, &argv); > You sure there wasn't a reason for these to be set in the opposite order? I'm not 100% sure. It was changed by Todd in his version of the patch, though: https://gerrit.cloudera.org/#/c/5563/2/src/kudu/tools/tool_main.cc -- To view, visit http://gerrit.cloudera.org:8080/5566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
