Adar Dembo has posted comments on this change. Change subject: KUDU-1812: redact HexDump output ......................................................................
Patch Set 2: Code-Review+2 I took a look at all the HexDump() callers, ignoring the test-only ones. There are a few places where, if there was corruption, we may get a slightly less useful log message. But, most are on read paths, where it's very likely that the corruption is deterministic and repeatable. So, asking a user to disable redaction temporarily to reproduce the corruption and yield a better error message is a possibility. tl;dr: I'm OK with this. -- To view, visit http://gerrit.cloudera.org:8080/5567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8388b19801382c491c9bcd9a485b1978ec0f007e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
