Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5578
to look at the new patch set (#2).
Change subject: [KUDU-90] Add a header checksum to our RPC protocol Added
4-byte checksum into the RPC protocol. Checksum is inserted immediately after
total_size.
......................................................................
[KUDU-90] Add a header checksum to our RPC protocol
Added 4-byte checksum into the RPC protocol.
Checksum is inserted immediately after total_size.
The new message framing will be
total_size: (32-bit big-endian integer)
the size of the rest of the message, not including this 4-byte header and
also not including 4-byte checksum
header_checksum: (32-bit big-endian integer) CRC-32
the checksum of header (excluding varint-prefixed header size field)
- CRC-32 computation in C++ uses `boost/crc.hpp`.
- CRC-32 computation in Java is based on hadoop-common class,
`org.apache.hadoop.util.PureJavaCrc32`
header: varint-prefixed header protobuf
- client->server messages use the RequestHeader protobuf
- server->client messages use the ResponseHeader protobuf
...
This is a non-backward compatible change.
Change-Id: Icf71ed4d4ac924445606b0d6fcf477d025243c74
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
A java/kudu-client/src/main/java/org/apache/kudu/util/Crc32.java
A java/kudu-client/src/test/java/org/apache/kudu/client/TestRpcChecksum.java
M src/kudu/rpc/constants.h
M src/kudu/rpc/serialization.cc
6 files changed, 758 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/5578/2
--
To view, visit http://gerrit.cloudera.org:8080/5578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf71ed4d4ac924445606b0d6fcf477d025243c74
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
