Alexey Serbin has posted comments on this change. Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin ......................................................................
Patch Set 7: (1 comment) Thank you for the review! I'll address the comments a little bit later. http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/README.md File java/kudu-jepsen/README.md: Line 16: Note that commas (not spaces) are used to separate the names of the machines. > Would it be possible to let the shell expand the node list? For example: I'm not sure that's possible: the issue here is with passing those parameters into maven plugin if those parameters are separated by space (even without any expansion). In other words, having -DtserverNodes="a b c" in command line does not work. Of course, it would be nice to fix that, but I'm not sure that's the thing we want to spend our time. However, if the workaround exists, we could try to use it. -- To view, visit http://gerrit.cloudera.org:8080/5551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
