Adar Dembo has submitted this change and it was merged.

Change subject: Fix flakiness in ToolTest.TestRemoteReplicaCopy
......................................................................


Fix flakiness in ToolTest.TestRemoteReplicaCopy

This test created a table, and then immediately asserted on the error
message returned when trying to copy a tablet on top of an existing
tablet. In fact, the destination tablet might still be in the 'creating'
transition, in which case the copy attempt failed with an unexpected
error message.

This patch fixes the issue by waiting for the RUNNING state first.

Tested a loop 500x with 4 stress threads in a RELEASE build (where this
seemed to be most flaky according to the dashboard).

Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Reviewed-on: http://gerrit.cloudera.org:8080/5543
Tested-by: Kudu Jenkins
Reviewed-by: Dinesh Bhat <[email protected]>
Reviewed-by: Adar Dembo <[email protected]>
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Dinesh Bhat: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dinesh Bhat <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>

Reply via email to