Mike Percy has posted comments on this change. Change subject: thirdparty: Link curl against el6 workaround openssl ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5603/1//COMMIT_MSG Commit Message: Line 7: thirdparty: Link curl against el6 workaround openssl > Should probably add a note about why we can't just remove curl from thirdpa Done http://gerrit.cloudera.org:8080/#/c/5603/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 505: CXXFLAGS="$EXTRA_CXXFLAGS $CURL_EXTRA_CXXFLAGS" \ > Curl is C-based, so I'm surprised this works. Shouldn't it be CFLAGS? Ah, indeed. It was not taking effect. When I use CFLAGS configure complains that CPPFLAGS should be used for include directories. So I did that and it is converting my -I<foo> to -isystem <foo> after specifying it via CPPFLAGS. So I guess it works now. Added a comment about that. -- To view, visit http://gerrit.cloudera.org:8080/5603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19e6be946853a80dad0f496839212887e76db06f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
