Jun He has posted comments on this change. Change subject: KUDU-734. Add test coverage for encodings and strings ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5588/1//COMMIT_MSG Commit Message: Line 9: added a TestEncodings class to check various encodings for all column types > I'm not sure this belongs in the Java client tests. We already have similar Thanks for the explanation. I found that `TestRowResult` has covered setting/getting all of the available column types. This test improved the coverage by setting/getting all of the available primary key types, which is not covered by TestKeyEncoding. I think I can merge it into TestKeyEncoding class. I will push the new change. http://gerrit.cloudera.org:8080/#/c/5588/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestStrings.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestStrings.java: Line 51: public void testMultiStringColumnsInsert() throws Exception { > I think this is already covered by TestKuduClient#testStrings() (the right- Done Line 90: public void testUTF8StringEncoding() throws Exception { > I think this is already covered by TestKuduClient#testUTF8 added in df02bb4 Not a problem. I will remove it. -- To view, visit http://gerrit.cloudera.org:8080/5588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3fbeb0f889a4c454a48d11a6e42c7da0e58a329 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He <[email protected]> Gerrit-Reviewer: Jun He <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
