Alexey Serbin has posted comments on this change. Change subject: KUDU-1733. Update consistency semantics doc ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5605/2/docs/transaction_semantics.adoc File docs/transaction_semantics.adoc: PS2, Line 135: nit: remove an extra space PS2, Line 137: Java Client:: Call `AsyncKuduClient#getLastPropagatedTimestamp()` on client 'a', : propagate the timestamp to client 'b', and call : `AsyncKuduClient#setLastPropagatedTimestamp()` on client 'b'. : : {cpp} Client:: Call `KuduClient::GetLatestObservedTimestamp()` on client _a_, : propagate the timestamp to client _b_, and call : `KuduClient::SetLatestObservedTimestamp()` on client _b_. nit: consider using the same style, like _a_ and _b_ or 'a' and 'b'. PS2, Line 221: https://issues.cloudera.org/browse/KUDU-1188[KUDU-1188] nit: consider updating the JIRA links to point at issues hosted at https://issues.apache.org/ PS2, Line 247: minpoll 1 nit: minpoll 1 isn't effectively applied -- the minimum poll is 3 (i.e. 2^3 = 8 seconds). That's out of the scope of this patch, though. PS2, Line 248: - `tinker dispersion 500` : - `tinker allan 0` I don't think this would help, but if there is some evidence showing otherwise, then it's fine. Anyway, that's out of the scope of this patch. -- To view, visit http://gerrit.cloudera.org:8080/5605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a59315e70531c8904470c026030f4cc2107ca5b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
