John Russell has posted comments on this change. Change subject: Doc review for 1.2 ......................................................................
Patch Set 1: (7 comments) Just skimmed quickly on the first pass. http://gerrit.cloudera.org:8080/#/c/5676/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: PS1, Line 376: DISTRIBUTE BY HASH INTO (id) 16 BUCKETS > DISTRIBUTE BY HASH (id) PARTITIONS 16 You mean PARTITION BY HASH (id) PARTITIONS 16 right? PS1, Line 413: DISTRIBUTE BY HASH(name) INTO 8 BUCKETS Also new syntax: PARTITION BY HASH(name) PARTITIONS 8 PS1, Line 448: DISTRIBUTE BY RANGE (_id) PARTITION BY In my experiments I thought there wasn't a way to have just range partitioning, that it had to by HASH and then optionally RANGE. Is that a misconception on my part? PS1, Line 449: SPLIT ROWS((1439560049342), : (1439566253755), : (1439572458168), : (1439578662581), : (1439584866994), : (1439591071407)) Now the syntax is different with 'PARTITION x <= VALUES < y'. I'm not sure how that plays out for the specific partitions in this example. PS1, Line 482: '\<', '\>', `>=`, or `IN` Does this apply for BETWEEN also, since that acts the same as a couple of comparisons chained together? PS1, Line 724: re-enable when documenting : // Impala 2.8. Aren't we documenting Impala 2.8 now or is this some intermediate stage? PS1, Line 941: 8 I thought it was still true. You have to alter the TBLPROPERTIES kudu.table_name to make Impala rename the underlying Kudu table. -- To view, visit http://gerrit.cloudera.org:8080/5676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
